-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarification / Best Practice required on how to handle multiple analyzer-result.yml files #4364
Comments
Sounds like a good fit a new |
@sschuberth We are currently in the process of implementing this function. Once ready, we are going to create a pull request. |
@porsche-rishisaxena, FYI, I can only assign @nikpete as he's the reporter (and none of you are project members, yet). |
This helper CLI function is used by Porsche to solve the issue oss-review-toolkit#4364 The rationale behind this is that some projects at Porsche deliver individual analyzer-results for each subproject in a large monorepo. The FOSS analysts need to see a condensed form of the individual dependency graphs across the project monorep. We solve this issue by merging all individual analyzer results into one. Signed-off-by: Rainer Bieniek <extern.rainer.bieniek@porsche.de>
Porsche solution submitted as #5315 |
For reference, if all code is located in Git repositories, a possible workaround for this issue is to create a new Git repository with all the other Git repositories as submodules. You can then use the new Git repository as input for the analyzer to get a single analyzer result with correct provenance information for all projects. |
…view-toolkit#4364 The rationale behind this is that some projects at Porsche deliver individual analyzer-results for each subproject in a large monorepo. The FOSS analysts need to see a condensed form of the individual dependency graphs across the project monorep. We solve this issue by merging all individual analyzer results into one. This commit fixes issues raised during the community code review. Signed-off-by: Rainer Bieniek <extern.rainer.bieniek@porsche.de>
This helper CLI function is used by Porsche to solve the issue oss-review-toolkit#4364 The rationale behind this is that some projects at Porsche deliver individual analyzer-results for each subproject in a large monorepo. The FOSS analyst needs to see a condensed form of the individual dependency graphs across the project monorepo. We solve this issue by merging all individual analyzer results into one. Signed-off-by: Rainer Bieniek <extern.rainer.bieniek@porsche.de>
I have a hunch that we're jumping to conclusions too quickly with implying that merging (analyzer) result files is the right approach. Let's step back a bit and ask ourselves what we want to achieve. From re-reading @nikpete's OP my guess is that in the end only a single / combined report (i.e. attribution document) is needed. As attribution documents contain far less information than full-blown ORT result files, maybe the better approach is to not merge ORT result files beforehand at all, but to create a special reporter that can take multiple ORT result files and simply attributes to the union of all contained projects / packages in a single report? |
This helper CLI function is used by Porsche to solve the issue oss-review-toolkit#4364 The rationale behind this is that some projects at Porsche deliver individual analyzer-results for each subproject in a large monorepo. The FOSS analyst needs to see a condensed form of the individual dependency graphs across the project monorepo. We solve this issue by merging all individual analyzer results into one. Signed-off-by: Rainer Bieniek <extern.rainer.bieniek@porsche.de>
All,
We do have several use cases where an overarching project might consists of multiple services and product teams. Therefore, multiple analyzer-result.yml file will be submitted (let's say 10+) because the project is simply not able to generate ONE .yml file (i.e. technical restrictions, mono repo)
Thanks,
Nik
The text was updated successfully, but these errors were encountered: