Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

License texts for + variants of SPDX licenses #5004

Closed
mmurto opened this issue Jan 28, 2022 · 1 comment · Fixed by #5035
Closed

License texts for + variants of SPDX licenses #5004

mmurto opened this issue Jan 28, 2022 · 1 comment · Fixed by #5035
Labels
enhancement Issues that are considered to be enhancements spdx-utils About the SPDX utility library

Comments

@mmurto
Copy link
Contributor

mmurto commented Jan 28, 2022

ORT currently provides license text for license identifiers on the SPDX license list for notice generation with Reporter. No license text is provided for SPDX licenses with + identifier; for example, a license expression LPPL-1.0+ does not produce any license text for the notice files.

Should the non-plus variant of the license be used for the plus variants?
@sschuberth sschuberth added enhancement Issues that are considered to be enhancements scanner About the scanner tool labels Jan 28, 2022
mnonnenmacher added a commit that referenced this issue Feb 10, 2022
@mnonnenmacher
spdx-utils: Ignore the '+' flag for SPDX license texts
b345293 
Ignore the '+' flag when getting the license text of an SPDX license.
For example, for the id 'Apache-2.0+' return the license text for
'Apache-2.0'. This is valid, because in the example 'Apache-2.0' is a
valid license for the expression.

Choosing a later version of the license should be implemented as an
extension of the license choice feature.

Fixes #5004.

Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@bosch.io>
@mnonnenmacher mnonnenmacher mentioned this issue Feb 10, 2022
Merged
@mnonnenmacher
Copy link
Member

@mmurto This was discussed in the developer meeting today and the consensus was that it should be implemented as suggested.

mnonnenmacher added a commit that referenced this issue Feb 10, 2022
@mnonnenmacher
spdx-utils: Ignore the '+' operator for SPDX license texts
e82ae55 
Ignore the '+' operator when getting the license text of an SPDX
license. For example, for the id 'Apache-2.0+' return the license text
for 'Apache-2.0'. This is valid, because in the example 'Apache-2.0' is
a valid license for the expression.

Choosing a later version of the license should be implemented as an
extension of the license choice feature.

Fixes #5004.

Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@bosch.io>
mnonnenmacher added a commit that referenced this issue Feb 10, 2022
@mnonnenmacher
spdx-utils: Ignore the '+' operator for SPDX license texts
8b19f27 
Ignore the '+' operator when getting the license text of an SPDX
license. For example, for the id 'Apache-2.0+' return the license text
for 'Apache-2.0'. This is valid, because in the example 'Apache-2.0' is
a valid license for the expression.

Choosing a later version of the license should be implemented as an
extension of the license choice feature.

Fixes #5004.

Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@bosch.io>
@mnonnenmacher mnonnenmacher added spdx-utils About the SPDX utility library and removed scanner About the scanner tool labels Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Issues that are considered to be enhancements spdx-utils About the SPDX utility library
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

spdx-utils: Ignore the '+' operator for SPDX license texts oss-review-toolkit/ort
3 participants
@sschuberth @mmurto @mnonnenmacher