Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "provider" to "type" in an Identifier #1088

Merged
merged 1 commit into from
Dec 3, 2018
Merged

Rename "provider" to "type" in an Identifier #1088

merged 1 commit into from
Dec 3, 2018

Conversation

sschuberth
Copy link
Member

@sschuberth sschuberth commented Dec 3, 2018

Also see the related purl discussion at [1]. What we were meaning by
"provider" actually more resembles purl's "type".

[1] package-url/purl-spec#33

Signed-off-by: Sebastian Schuberth sebastian.schuberth@here.com


This change is Reviewable

Also see the related purl discussion at [1]. What we were meaning by
"provider" actually more resembles purl's "type".

[1] package-url/purl-spec#33

Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
@codecov
Copy link

codecov bot commented Dec 3, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@4c86246). Click here to learn what that means.
The diff coverage is 76.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1088   +/-   ##
=========================================
  Coverage          ?   52.05%           
  Complexity        ?      298           
=========================================
  Files             ?      117           
  Lines             ?     5802           
  Branches          ?      844           
=========================================
  Hits              ?     3020           
  Misses            ?     2341           
  Partials          ?      441
Impacted Files Coverage Δ Complexity Δ
downloader/src/main/kotlin/Downloader.kt 32.06% <0%> (ø) 0 <0> (?)
cli/src/main/kotlin/commands/DownloaderCommand.kt 8.19% <0%> (ø) 1 <0> (?)
analyzer/src/main/kotlin/managers/Gradle.kt 82.79% <100%> (ø) 0 <0> (?)
analyzer/src/main/kotlin/PackageManager.kt 95.71% <100%> (ø) 0 <0> (?)
analyzer/src/main/kotlin/managers/PhpComposer.kt 74.6% <100%> (ø) 0 <0> (?)
analyzer/src/main/kotlin/managers/PIP.kt 68.87% <100%> (ø) 0 <0> (?)
analyzer/src/main/kotlin/managers/Stack.kt 85.8% <100%> (ø) 0 <0> (?)
analyzer/src/main/kotlin/MavenSupport.kt 79.03% <100%> (ø) 0 <0> (?)
analyzer/src/main/kotlin/managers/Maven.kt 67.94% <100%> (ø) 0 <0> (?)
analyzer/src/main/kotlin/managers/NPM.kt 82.4% <100%> (ø) 0 <0> (?)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c86246...d178e75. Read the comment docs.

@sschuberth sschuberth merged commit 1a44e0e into master Dec 3, 2018
@sschuberth sschuberth deleted the id-type branch December 3, 2018 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants