Do not override toString() for the Identifier anymore #1266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sschuberth
force-pushed
the
id-no-tostring
branch
6 times, most recently
from
fd49f8a
to
fb27ae4
Compare
sschuberth
changed the title
sschuberth
force-pushed
the
id-no-tostring
branch
9 times, most recently
from
cf28e50
to
e0e5a80
Compare
This is a fixup for 3209b28. Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
getValue() throws an exception if the key does not exist and thus always returns a non-nullable value. Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
Besides the known benefits when refactoring, this allows for adding e.g. a toPurl() function instead of having to decide for toString() to return either coordinates or a package URL [1]. [1] https://github.com/package-url/purl-spec Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
This is unused so far, but serves as a reference. Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
sschuberth
force-pushed
the
id-no-tostring
branch
from
e0e5a80
to
cf43b8f
Compare
sschuberth
changed the title
|
@mnonnenmacher, this is now also ready for review. I've removed the BOOM! commit as overriding the different |
mnonnenmacher
requested changes
Feb 7, 2019
sschuberth
force-pushed
the
id-no-tostring
branch
from
cf43b8f
to
68d8c37
Compare
mnonnenmacher
approved these changes
Feb 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.
This change is