Upgrade ScanCode to 30.1.0 #4916
Conversation
| @@ -73,6 +73,19 @@ class ScanCodeResultParserTest : WordSpec({ | |||
| } | |||
| } | |||
|
|
|||
| "ScanCode 30 results" should { | |||
There was a problem hiding this comment.
This (and other test names) should probably consistently refer to either "30.1.0" or "30.*". Or maybe yet better, we should stop referring to the ScanCode version at all, and instead refer to the "output_format_version" written in the JSON, which current is at 1.0.0.
There was a problem hiding this comment.
I have renamed the new tests, but the old test assets don't have an "output_format_version" so I have kept them as is.
There was a problem hiding this comment.
the old test assets don't have an "output_format_version" so I have kept them as is.
That's because the "output_format_version" JSON property was just recently introduced, see aboutcode-org/scancode-toolkit#2653 (comment).
Align some formatting with the official Kotlin code style. Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@bosch.io>
mnonnenmacher
force-pushed
the
scancode-30.1.0
branch
from
82a1db4
to
894d852
Compare
scanner/src/test/kotlin/scanners/scancode/ScanCodeResultParserTest.kt
Outdated
Show resolved
Hide resolved
See [1] for all changes since version 3.2.1rc2. [1]: https://github.com/nexB/scancode-toolkit/blob/develop/CHANGELOG.rst#3010---2021-09-25 Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@bosch.io>
mnonnenmacher
force-pushed
the
scancode-30.1.0
branch
from
894d852
to
c873c92
Compare
|
@tsteenbe please remember to also approve once you're fine with merging. |
Upgrade the default ScanCode version to 30.1.0, see the commit messages for details.