SpdxDocumentModelMapper: Make SPDX "idstring" generation predictable #5225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Being able to predict the SPDX "idstring" for a given package is a prerequisite for upcoming changes that will maintain the transitive package relationships. The SPDX ID is now derived from the coordinate representation of a project's / package's `Identifier`. As the `Identifier` is unique within an `OrtResult`, the derived SPDX ID is very likely unique, too, except for cases where coordinate representations differ only in special characters that get mapped to the same valid character for an SPDX ID. Signed-off-by: Sebastian Schuberth <sebastian.schuberth@bosch.io>
|
@fviernau I hope this aligns with what we discussed. |
mnonnenmacher
approved these changes
Apr 6, 2022
|
Am I correct that we now write use "first" instead of "1" |
tsteenbe
approved these changes
Apr 7, 2022
This has been clarified in today's ORT developer meeting. The short answer is "no" 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Being able to predict the SPDX "idstring" for a given package is a
prerequisite for upcoming changes that will maintain the transitive
package relationships.
The SPDX ID is now derived from the coordinate representation of a
project's / package's
Identifier. As theIdentifieris unique withinan
OrtResult, the derived SPDX ID is very likely unique, too, exceptfor cases where coordinate representations differ only in special
characters that get mapped to the same valid character for an SPDX ID.
Signed-off-by: Sebastian Schuberth sebastian.schuberth@bosch.io