PackageConfiguration: Support matching any revision
#5233
Conversation
In exchange for the speaking function name, add a code comment. Signed-off-by: Sebastian Schuberth <sebastian.schuberth@bosch.io>
|
@fviernau, after another discussion with @mnonnenmacher we decided to propose this change without hiding it behind a feature toggle. The reason mostly is that any such conventions like requiring a fixed So, what do you think @fviernau? |
Codecov Report
@@ Coverage Diff @@
## main #5233 +/- ##
============================================
- Coverage 72.30% 72.30% -0.01%
Complexity 1945 1945
============================================
Files 259 259
Lines 13826 13836 +10
Branches 1950 1950
============================================
+ Hits 9997 10004 +7
- Misses 2796 2798 +2
- Partials 1033 1034 +1
Continue to review full report at Codecov.
|
| */ | ||
| val revision: String | ||
| @JsonInclude(JsonInclude.Include.NON_NULL) | ||
| val revision: String? = null |
There was a problem hiding this comment.
Please also update docs/config-file-package-configuration-yml.md, maybe just add "(optional)" before the one mention of the revision property.
Allow to omit a `VcsMatcher`'s `revision` to match any `resolvedRevision` from a `RepositoryProvenance`. This is especially useful when working with `SpdxDocumentFile`s that define packages in subdirectories of the project's repository, as it avoids the `revision` to be updated whenever commits to the project (not the package) are being made. Resolves #4196. Signed-off-by: Sebastian Schuberth <sebastian.schuberth@bosch.io>
sschuberth
force-pushed
the
pkg-conf-rev-matching
branch
from
da2a0b8
to
1ebfc8b
Compare
Please have a look at the individual commit messages for the details.