LicenseClassifications: Exclude properties from serialization #5882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Frank Viernau <frank_viernau@epam.com>
Signed-off-by: Frank Viernau <frank_viernau@epam.com>
A `license-classifications.yml` is supposed to contain only the two properties defined in the constructor of the class. So, exclude all other properties from serialization. Note that just `@JsonIgnore` cannot be used instead of `@get:JsonIgnore`, as that causes a compile error, see [1]. [1] FasterXML/jackson-module-kotlin#25 Signed-off-by: Frank Viernau <frank_viernau@epam.com>
Codecov ReportBase: 67.87% // Head: 57.92% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #5882 +/- ##
============================================
- Coverage 67.87% 57.92% -9.95%
- Complexity 2172 2265 +93
============================================
Files 272 329 +57
Lines 15984 19119 +3135
Branches 2870 3753 +883
============================================
+ Hits 10849 11075 +226
- Misses 3994 6896 +2902
- Partials 1141 1148 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
mnonnenmacher
approved these changes
Sep 29, 2022
fviernau
added a commit
to oss-review-toolkit/ort-config
that referenced
this pull request
Sep 29, 2022
This revision has the fix for serializing license classifications, see oss-review-toolkit/ort#5882. Signed-off-by: Frank Viernau <frank_viernau@epam.com>
fviernau
added a commit
to oss-review-toolkit/ort-config
that referenced
this pull request
Oct 10, 2022
This revision has the fix for serializing license classifications, see oss-review-toolkit/ort#5882. Signed-off-by: Frank Viernau <frank_viernau@epam.com>
fviernau
added a commit
to oss-review-toolkit/ort-config
that referenced
this pull request
Oct 10, 2022
This revision has the fix for serializing license classifications, see oss-review-toolkit/ort#5882. Signed-off-by: Frank Viernau <frank_viernau@epam.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
This enables using the serialization in oss-review-toolkit/ort-config#59.