docker: Build and run as a non-privileged user #6053
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heliocastro
added
enhancement
heliocastro
requested review from
fviernau,
mnonnenmacher,
nicorikken and
tsteenbe
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
heliocastro
force-pushed
the
hcc/docker_as_a_user
branch
from
ad228f8
to
efce22c
Compare
heliocastro
force-pushed
the
hcc/docker_as_a_user
branch
2 times, most recently
from
e3c01b6
to
3419189
Compare
|
Could you please break the changes to the |
heliocastro
force-pushed
the
hcc/docker_as_a_user
branch
from
3419189
to
60caf66
Compare
heliocastro
removed request for
tsteenbe,
mnonnenmacher,
nicorikken and
fviernau
tsteenbe
reviewed
Nov 9, 2022
heliocastro
force-pushed
the
hcc/docker_as_a_user
branch
from
60caf66
to
e9d06be
Compare
heliocastro
force-pushed
the
hcc/docker_as_a_user
branch
2 times, most recently
from
1aa71f6
to
f9804d8
Compare
heliocastro
force-pushed
the
hcc/docker_as_a_user
branch
3 times, most recently
from
892888c
to
c4b2bef
Compare
heliocastro
requested review from
mnonnenmacher,
nicorikken,
fviernau and
tsteenbe
heliocastro
force-pushed
the
hcc/docker_as_a_user
branch
from
c4b2bef
to
ac1f179
Compare
- Shell in login profile is not more needed - Container runs always on the defined build user ( default: ort ) - Added an auxiliary script for apt proxy - Detect platform for build. scancode is disabled on linux/arm64 Signed-off-by: Helio Chissini de Castro <heliocastro@gmail.com>
heliocastro
force-pushed
the
hcc/docker_as_a_user
branch
from
ac1f179
to
e83c6fe
Compare
nicorikken
approved these changes
Nov 11, 2022
While the changes in sum may be good, it's still all done in one bulk commit. Please split this into logical steps / semantically atomic commits to separate independent changes from another like @nnobelis was already asking for above. |
|
Superseeded |
Mind adding a link with what this is being superseded, for reference? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Helio Chissini de Castro heliocastro@gmail.com
Please ensure that your pull request adheres to our contribution guidelines. Thank you!