Fix an issue with CuratedPackage.toUncuratedPackage() #6413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could it be commit-lint is running into this bug? conventional-changelog/commitlint#896 |
fviernau
force-pushed
the
to-uncurated-package
branch
from
af774e5
to
8656e94
Compare
Simplify a following change. Signed-off-by: Frank Viernau <frank_viernau@epam.com>
The implementation of `toUncuratedPackage()` does not work for `null` values in all cases due to lack of data, see also #5637. The representation of `OrtResult` has been changed recently to store the original / uncurated packages instead of the curated ones. So, make use of that new representation to always obtain the correct uncurated package. Fixes #5637. Signed-off-by: Frank Viernau <frank_viernau@epam.com>
Make the naming consistent with getPackageOrProject(). Signed-off-by: Frank Viernau <frank_viernau@epam.com>
The function is very similar to getUncuratedPackageOrProject(), so it should be located nearby for consistency. Signed-off-by: Frank Viernau <frank_viernau@epam.com>
Return a `CuratedPackage` instead of a `Package` to make it clearer that the returned package is actually curated. Signed-off-by: Frank Viernau <frank_viernau@epam.com>
Make the implementation consistent with `getUncuratedPackageOrProject()`. Note: The implementation now also better aligns with the function name. Signed-off-by: Frank Viernau <frank_viernau@epam.com>
fviernau
force-pushed
the
to-uncurated-package
branch
from
8656e94
to
728697c
Compare
mnonnenmacher
approved these changes
Feb 1, 2023
Looks like it, maybe the |
|
Merged despite unrelated test failures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get rid of the "not always correctly working" [1]
toUncuratedPackage()by utilizing the original uncurated packages from theOrtResult. While at it, do a couple of clean-ups for relatedOrtResultgetters and their callers.[1] #5637.
BREAKING CHANGE: Only for programmatic use of ORT:
OrtResultinstead of from the removedtoUncuratedPackage().