Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curation provider configuration stuff #7013

Merged
merged 2 commits into from
May 17, 2023
Merged

Conversation

sschuberth
Copy link
Member

Please have a look at the individual commit messages for the details.

…iders

Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
@sschuberth
Copy link
Member Author

@oss-review-toolkit/core-devs it just struck me in the context of this PR that ORT is not using its own curations from ORT config by default. Any concerns / objections to do that?

@sschuberth sschuberth requested a review from a team May 17, 2023 13:54
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Patch coverage: 84.61% and no project coverage change.

Comparison is base (4a1cb6c) 64.29% compared to head (0e229e3) 64.29%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #7013   +/-   ##
=========================================
  Coverage     64.29%   64.29%           
- Complexity     1969     1970    +1     
=========================================
  Files           331      331           
  Lines         16706    16719   +13     
  Branches       2381     2383    +2     
=========================================
+ Hits          10741    10750    +9     
- Misses         4928     4929    +1     
- Partials       1037     1040    +3     
Flag Coverage Δ
test 40.17% <84.61%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
model/src/main/kotlin/config/OrtConfiguration.kt 97.67% <ø> (ø)
advisor/src/main/kotlin/advisors/OssIndex.kt 84.00% <75.00%> (-2.67%) ⬇️
...del/src/main/kotlin/config/AdvisorConfiguration.kt 97.61% <100.00%> (+7.87%) ⬆️
...src/main/kotlin/licenses/LicenseClassifications.kt 96.42% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sschuberth
Copy link
Member Author

Merging despite the unrelated test failure.

@sschuberth sschuberth merged commit ae5751b into main May 17, 2023
@sschuberth sschuberth deleted the curation-provider-config-docs branch May 17, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants