Add CycloneDX metadata #7405
Merged
Add CycloneDX metadata #7405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #7405 +/- ##
============================================
- Coverage 60.91% 60.91% -0.01%
Complexity 1968 1968
============================================
Files 338 338
Lines 16622 16623 +1
Branches 2365 2365
============================================
Hits 10126 10126
- Misses 5518 5519 +1
Partials 978 978
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
sschuberth
force-pushed
the
cdx-metadata
branch
from
7224841
to
60839c4
Compare
5 tasks
mnonnenmacher
requested changes
Aug 24, 2023
| @@ -25,10 +25,12 @@ import com.fasterxml.jackson.databind.annotation.JsonSerialize | |||
|
|
|||
| import org.ossreviewtoolkit.utils.common.getDuplicates | |||
| import org.ossreviewtoolkit.utils.spdx.SpdxConstants.REF_PREFIX | |||
| import org.ossreviewtoolkit.utils.spdx.SpdxLicense | |||
There was a problem hiding this comment.
Commit message nit: "a hard-coded"
To avoid replacing unintended strings, replace only the first occurrence in the header section before the components start. This is a preparation for adding more replacements. Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
This increases the score with tools like sbomqs [1]. Also see [2]. [1]: https://github.com/interlynk-io/sbomqs [2]: interlynk-io/sbombenchmark.dev#11 Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
By default, use CC0-1.0 as the license, just like for SPDX data. Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
sschuberth
force-pushed
the
cdx-metadata
branch
from
60839c4
to
3758b59
Compare
Avoid typos and ease refactoring by using the appropriate `enum` value for the license ID instead of a hard-coded string. Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
sschuberth
force-pushed
the
cdx-metadata
branch
from
3758b59
to
59d1c2c
Compare
mnonnenmacher
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.