SPDX creator tool adjustments #7410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #7410 +/- ##
=========================================
Coverage 60.91% 60.91%
Complexity 1968 1968
=========================================
Files 338 338
Lines 16622 16622
Branches 2365 2365
=========================================
Hits 10126 10126
Misses 5518 5518
Partials 978 978
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was referenced Aug 23, 2023
fviernau
requested changes
Aug 23, 2023
plugins/reporters/spdx/src/funTest/assets/spdx-document-reporter-expected-output.spdx.json
Show resolved
Hide resolved
plugins/reporters/spdx/src/main/kotlin/SpdxDocumentModelMapper.kt
Outdated
Show resolved
Hide resolved
Just like for persons, also trim organization names to be on the safe side. This is a preparation for an upcoming change. Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
sschuberth
force-pushed
the
ort-spdx-tool
branch
2 times, most recently
from
c0e0a5c
to
c64c453
Compare
The constants are more convenient to use when they do not include the trailing space: At the example of this commit's diff, it is now clear that the interpolated string is not a single word. This also makes creator parsing more lenient as the space after the colon is not strictly required anymore, which is something that the SPDX spec is not clear about. Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
While the SPDX spec is not clear about this, the example [1] suggests that tool names should follow the syntax `toolidentifier-version`, and some SPDX validation tools actually rely on this [2]. To be on the safe side, and as "ort" as a (short) tool name is already well known in the community, follow the example syntax and do not use spaces in the tool / version string. [1]: https://spdx.github.io/spdx-spec/v2.3/document-creation-information/#68-creator-field [2]: interlynk-io/sbombenchmark.dev#11 (comment) Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
sschuberth
force-pushed
the
ort-spdx-tool
branch
from
c64c453
to
fc140f0
Compare
fviernau
approved these changes
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.