WebApp: Reflect excluded affected paths of issues in the UI #8562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8562 +/- ##
=========================================
Coverage 67.70% 67.70%
Complexity 1007 1007
=========================================
Files 246 246
Lines 7924 7924
Branches 883 883
=========================================
Hits 5365 5365
Misses 2176 2176
Partials 383 383
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fviernau
force-pushed
the
webapp-combined
branch
4 times, most recently
from
f3bd08d
to
135225d
Compare
mnonnenmacher
requested changes
Apr 26, 2024
plugins/reporters/web-app-template/src/components/IssuesTable.jsx
Outdated
Show resolved
Hide resolved
fviernau
force-pushed
the
webapp-combined
branch
from
135225d
to
edb5bfe
Compare
mnonnenmacher
previously approved these changes
Apr 26, 2024
fviernau
force-pushed
the
webapp-combined
branch
from
edb5bfe
to
dd641f8
Compare
This can be useful for filtering issues, for example in reporters. Signed-off-by: Frank Viernau <frank_viernau@epam.com>
The property is supposed to be used to filter out excluded issues in the WebApp. Signed-off-by: Frank Viernau <frank_viernau@epam.com>
Align with the recently added corresponding property in `EvaluatedIssue`. Signed-off-by: Frank Viernau <frank_viernau@epam.com>
This recently added property is `true` if and only if the related corresponding package is excluded or if the corresponding non-null affected path is excluded. So, the exclusion filter in the issues tab as of this change handles excluded affected paths of issues. Signed-off-by: Frank Viernau <frank_viernau@epam.com>
fviernau
force-pushed
the
webapp-combined
branch
from
dd641f8
to
dc03962
Compare
tsteenbe
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The effect on the UI is visible only under the issues summary view and is as follows:
Note: This PR can be easily verified by creating a WebApp report from
./plugins/reporters/evaluated-model/src/funTest/assets/reporter-test-input.yml.Part of: #7921.
UI Changes
Gradle:org.ossreviewtoolkit.gradle.example:lib:1.0.0now grayed out: