static-html: Model mapper clean-ups #8615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fviernau
force-pushed
the
tables-report-model-mapper-cleanups
branch
from
9a7f556
to
b8738ca
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8615 +/- ##
=========================================
Coverage 67.97% 67.97%
Complexity 1005 1005
=========================================
Files 244 244
Lines 7844 7844
Branches 876 876
=========================================
Hits 5332 5332
Misses 2129 2129
Partials 383 383
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sschuberth
requested changes
May 3, 2024
plugins/reporters/static-html/src/main/kotlin/TablesReportModelMapper.kt
Show resolved
Hide resolved
plugins/reporters/static-html/src/main/kotlin/TablesReportModelMapper.kt
Show resolved
Hide resolved
plugins/reporters/static-html/src/main/kotlin/TablesReportModelMapper.kt
Show resolved
Hide resolved
plugins/reporters/static-html/src/main/kotlin/TablesReportModelMapper.kt
Outdated
Show resolved
Hide resolved
fviernau
force-pushed
the
tables-report-model-mapper-cleanups
branch
from
b8738ca
to
4893dac
Compare
fviernau
force-pushed
the
tables-report-model-mapper-cleanups
branch
from
4893dac
to
5d57d68
Compare
sschuberth
reviewed
May 6, 2024
| @@ -1071,7 +1067,7 @@ <h3 class="">Packages</h3> | |||
| </td> | |||
| <td><em>Concluded License:</em><dl> | |||
| <dd> | |||
| <div><a href="https://archive.softwareheritage.org/browse/content/sha1_git:a612ad9813b006ce81d1ee438dd784da99a54007">MPL-2.0</a> OR <a href="https://archive.softwareheritage.org/browse/content/sha1_git:2aa9b989e0fec475baf21544f8613cb53d03c3f7">EPL-1.0</a></div> | |||
| <div><a href="https://archive.softwareheritage.org/browse/content/sha1_git:2aa9b989e0fec475baf21544f8613cb53d03c3f7">EPL-1.0</a> OR <a href="https://archive.softwareheritage.org/browse/content/sha1_git:a612ad9813b006ce81d1ee438dd784da99a54007">MPL-2.0</a></div> | |||
There was a problem hiding this comment.
From just quickly looking at this: Shouldn't things just get reordered? But it seems that original content got lost.
There was a problem hiding this comment.
I hope I'm not missing anything, but I believe nothing got lost but really just re-ordered.
Is this maybe a GitHub UI rendering issue in the diff view?
before:
<div><a href="https://archive.softwareheritage.org/browse/content/sha1_git:a612ad9813b006ce81d1ee438dd784da99a54007">MPL-2.0</a> OR <a href="https://archive.softwareheritage.org/browse/content/sha1_git:2aa9b989e0fec475baf21544f8613cb53d03c3f7">EPL-1.0</a></div>
after:
<div><a href="https://archive.softwareheritage.org/browse/content/sha1_git:2aa9b989e0fec475baf21544f8613cb53d03c3f7">EPL-1.0</a> OR <a href="https://archive.softwareheritage.org/browse/content/sha1_git:a612ad9813b006ce81d1ee438dd784da99a54007">MPL-2.0</a></div>
There was a problem hiding this comment.
Ah, I got confused because I was expecting lines to get reordered. Instead, terms with a single line got reordered 👍🏻
Reduce the size of the large `map()` function for a better overview. Signed-off-by: Frank Viernau <frank_viernau@epam.com>
It is not planned anymore to implement the mentioned change. Signed-off-by: Frank Viernau <frank_viernau@epam.com>
Simplify the exclude-related code in its caller a bit. Signed-off-by: Frank Viernau <frank_viernau@epam.com>
This allows to get rid of the `!!` call. Signed-off-by: Frank Viernau <frank_viernau@epam.com>
Signed-off-by: Frank Viernau <frank_viernau@epam.com>
Simply construct a `Set` instead of a sorted one and sort the rows later. While at it, use a shorter variable name and re-arrange the lines. Signed-off-by: Frank Viernau <frank_viernau@epam.com>
Signed-off-by: Frank Viernau <frank_viernau@epam.com>
Signed-off-by: Frank Viernau <frank_viernau@epam.com>
Establish consistency with the effective license. Signed-off-by: Frank Viernau <frank_viernau@epam.com>
Improve consistency. Signed-off-by: Frank Viernau <frank_viernau@epam.com>
fviernau
force-pushed
the
tables-report-model-mapper-cleanups
branch
from
5d57d68
to
f2bcea4
Compare
sschuberth
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
Part of: #7921.