Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(conan): Avoid deprecated section name #8759

Conversation

rettichschnidi
Copy link
Contributor

This change is a preparation for Conan 2.x support in ORT.

With Conan 2, the section build_requires in conanfile.txt has been renamed to tool_requires. The old name is no longer supported and causes Conan (2.x) to fail with an error:

$ conan install conanfile.txt
...
ConfigParser: Unrecognized field 'build_requires'

Starting with Conan 1.44, tool_requires has been added to Conan 1.x as an alias for build_requires. Ever since, the official documentation does not mention a section named build_requires anymore.

Current 1.x docs: https://docs.conan.io/en/1.64/reference/conanfile_txt.html
Old 1.x docs: https://docs.conan.io/en/1.43/reference/conanfile_txt.html
Relevant issue: conan-io/conan#10168

@rettichschnidi rettichschnidi marked this pull request as ready for review June 13, 2024 02:02
@rettichschnidi rettichschnidi requested a review from a team as a code owner June 13, 2024 02:02
This change is a preparation for Conan 2.x support in ORT.

With Conan 2, the section `build_requires` in conanfile.txt has been
renamed to `tool_requires`. The old name is no longer supported and
causes Conan (2.x) to fail with an error:

```shell
$ conan install conanfile.txt
...
ConfigParser: Unrecognized field 'build_requires'
```

Starting with Conan 1.44, `tool_requires` has been added to Conan 1.x as
an alias for `build_requires`. Ever since, the official documentation
does not mention a section named `build_requires` anymore.

Old: https://docs.conan.io/en/1.43/reference/conanfile_txt.html
New: https://docs.conan.io/en/1.64/reference/conanfile_txt.html
Relevant issue: conan-io/conan#10168

Signed-off-by: Reto Schneider <reto.schneider@husqvarnagroup.com>
@rettichschnidi rettichschnidi force-pushed the gardena/rs/upstream/conan-2-compatibility-tool-requires branch from 0215401 to 521150d Compare June 13, 2024 02:04
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.79%. Comparing base (6f50cf5) to head (521150d).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #8759   +/-   ##
=========================================
  Coverage     67.79%   67.79%           
  Complexity     1164     1164           
=========================================
  Files           243      243           
  Lines          7711     7711           
  Branches        861      861           
=========================================
  Hits           5228     5228           
  Misses         2127     2127           
  Partials        356      356           
Flag Coverage Δ
funTest-docker 66.84% <ø> (ø)
funTest-non-docker 33.96% <ø> (ø)
test 38.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sschuberth
Copy link
Member

sschuberth commented Jun 13, 2024

I have no problems with raising the min. supported Conan version to 1.44.0, but we should double-check with the community, so I've added it to the agenda of today's call (which I cannot attend, however).

However, doing this as a preparation for Conan 2 support probably does not count, as over here we assumed that Conan 2 support would be implemented via a new independent package manager with its own test assets.

@sschuberth
Copy link
Member

I've added it to the agenda of today's call (which I cannot attend, however).

I see that the community had no objections during the call, so let's move forward with this, even if not strictly required for Conan 2 support, which still could be implemented as a separate analyzer plugin.

@sschuberth sschuberth merged commit 5d0a178 into oss-review-toolkit:main Jun 17, 2024
20 checks passed
@rettichschnidi rettichschnidi deleted the gardena/rs/upstream/conan-2-compatibility-tool-requires branch July 11, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants