Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(github): Be explicit about artifact paths to attest for #8804

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

sschuberth
Copy link
Member

Work-around 1 and only attest the main artifacts, not the signature files.

@sschuberth sschuberth requested a review from a team as a code owner June 27, 2024 09:29
@sschuberth sschuberth enabled auto-merge (rebase) June 27, 2024 09:29
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.79%. Comparing base (f9e7f72) to head (8624fed).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #8804   +/-   ##
=========================================
  Coverage     67.79%   67.79%           
  Complexity     1164     1164           
=========================================
  Files           243      243           
  Lines          7711     7711           
  Branches        861      861           
=========================================
  Hits           5228     5228           
  Misses         2127     2127           
  Partials        356      356           
Flag Coverage Δ
test 38.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Work-around [1] and only attest the main artifacts, not the signature
files.

[1]: actions/attest-build-provenance#133

Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
@sschuberth sschuberth requested review from fviernau and a team June 27, 2024 10:38
@fviernau fviernau changed the title fix(github): Be explicity about artifact paths to attest for fix(github): Be explicit about artifact paths to attest for Jun 27, 2024
@sschuberth sschuberth merged commit c4b1d66 into main Jun 27, 2024
20 checks passed
@sschuberth sschuberth deleted the explicit-attestation-paths branch June 27, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants