chore(advisor)!: Remove the GitHub defects advisor #8994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8994 +/- ##
=========================================
Coverage 68.02% 68.02%
Complexity 1158 1158
=========================================
Files 241 241
Lines 7690 7690
Branches 867 867
=========================================
Hits 5231 5231
Misses 2103 2103
Partials 356 356
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This advisor does not seem to be used. Also, it depends on version 6 of the Expedia GraphQL library which in turn depends on an old version of the Ktor client that has known security vulnerability CVE-2023-45613. So just remove this advisor completely. Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
sschuberth
force-pushed
the
remove-github-defects-advisor
branch
from
9c60816
to
9f635c2
Compare
mnonnenmacher
approved these changes
Aug 19, 2024
This was referenced Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This advisor does not seem to be used. Also, it depends on version 6 of the Expedia GraphQL library which in turn depends on an old version of the Ktor client that has known security vulnerability CVE-2023-45613. So just remove this advisor completely.