Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update jackson to v2.18.0 #9209

Merged
merged 3 commits into from
Sep 30, 2024
Merged

deps: update jackson to v2.18.0 #9209

merged 3 commits into from
Sep 30, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 27, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
com.fasterxml.jackson.module:jackson-module-kotlin 2.17.2 -> 2.18.0 age adoption passing confidence
com.fasterxml.jackson.datatype:jackson-datatype-jsr310 2.17.2 -> 2.18.0 age adoption passing confidence
com.fasterxml.jackson.core:jackson-core 2.17.2 -> 2.18.0 age adoption passing confidence
com.fasterxml.jackson.core:jackson-annotations (source) 2.17.2 -> 2.18.0 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from a team as a code owner September 27, 2024 03:55
@renovate renovate bot added the dependencies Pull requests that update a dependency file label Sep 27, 2024
sschuberth
sschuberth previously approved these changes Sep 27, 2024
@sschuberth sschuberth enabled auto-merge (rebase) September 27, 2024 06:24
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.10%. Comparing base (2b08e9e) to head (f46fc43).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #9209   +/-   ##
=========================================
  Coverage     67.10%   67.10%           
  Complexity     1187     1187           
=========================================
  Files           240      240           
  Lines          7904     7904           
  Branches        908      908           
=========================================
  Hits           5304     5304           
  Misses         2232     2232           
  Partials        368      368           
Flag Coverage Δ
funTest-docker 60.23% <ø> (ø)
funTest-non-docker 34.56% <ø> (ø)
test 36.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor Author

renovate bot commented Sep 27, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@sschuberth
Copy link
Member

sschuberth commented Sep 27, 2024

@oheger-bosch please have a look at the DependencyGraph changes that I did to make AnalyzerResultBuilderTest pass with the new Jackson version. There was a problem with empty edges being re-serialized as null.

@oheger-bosch
Copy link
Member

@oheger-bosch please have a look at the DependencyGraph changes that I did to make AnalyzerResultBuilderTest pass with the new Jackson version. There was a problem with empty edges being re-serialized as null.

The changes look plausible to me. Maybe add a hint to the commit message why this changes was necessary for the upgrade to the new Jackson version?
Did you also check whether this change has an impact on the serialized form in the result YAML files?

The only reason to distinguish between `null` and empty nodes is to
decide whether nodes should be constructed from scope roots. However,
that check can be implemented by only looking for empty nodes as well.

Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
sschuberth and others added 2 commits September 30, 2024 08:03
Similar to nodes, edges being `null` was only used in the check to
construct nodes from scope roots. However, that check can be implemented
by looking at nodes alone.

This change avoids a failure in `AnalyzerResultBuilderTest` with upcoming
Jackson version 2.18.0 where empty edges would be re-serialized as
`null`.

Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
@sschuberth
Copy link
Member

Maybe add a hint to the commit message why this changes was necessary for the upgrade to the new Jackson version?

Done.

Did you also check whether this change has an impact on the serialized form in the result YAML files?

Due to @JsonInclude(JsonInclude.Include.NON_DEFAULT) on DependencyGraph I'm confident that there is no change in the serialized form as only the default value changes.

@sschuberth sschuberth merged commit cd61f12 into main Sep 30, 2024
23 checks passed
@sschuberth sschuberth deleted the renovate/jackson branch September 30, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants