-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update jackson to v2.18.0 #9209
Conversation
ba4b220
to
f0c4173
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9209 +/- ##
=========================================
Coverage 67.10% 67.10%
Complexity 1187 1187
=========================================
Files 240 240
Lines 7904 7904
Branches 908 908
=========================================
Hits 5304 5304
Misses 2232 2232
Partials 368 368
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
f0c4173
to
f924c29
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
@oheger-bosch please have a look at the |
f924c29
to
8424993
Compare
The changes look plausible to me. Maybe add a hint to the commit message why this changes was necessary for the upgrade to the new Jackson version? |
The only reason to distinguish between `null` and empty nodes is to decide whether nodes should be constructed from scope roots. However, that check can be implemented by only looking for empty nodes as well. Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
8424993
to
5f5c9fd
Compare
Similar to nodes, edges being `null` was only used in the check to construct nodes from scope roots. However, that check can be implemented by looking at nodes alone. This change avoids a failure in `AnalyzerResultBuilderTest` with upcoming Jackson version 2.18.0 where empty edges would be re-serialized as `null`. Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
5f5c9fd
to
f46fc43
Compare
Done.
Due to |
This PR contains the following updates:
2.17.2
->2.18.0
2.17.2
->2.18.0
2.17.2
->2.18.0
2.17.2
->2.18.0
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.