feat(fossid): Make FossID sensitivity configurable #9248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnobelis
requested changes
Oct 7, 2024
Juli0q
force-pushed
the
fossid-configurable-sensitivity
branch
from
9947926
to
fa6af64
Compare
Commit message nits: No reason to capitalize "User" and "Scan". |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9248 +/- ##
=========================================
Coverage 67.77% 67.77%
- Complexity 1187 1189 +2
=========================================
Files 239 239
Lines 7821 7821
Branches 904 904
=========================================
Hits 5301 5301
Misses 2153 2153
Partials 367 367
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Juli0q
force-pushed
the
fossid-configurable-sensitivity
branch
2 times, most recently
from
42438cc
to
183fdc5
Compare
Juli0q
force-pushed
the
fossid-configurable-sensitivity
branch
2 times, most recently
from
f5aba50
to
6d44b0b
Compare
|
@nnobelis, please re-review. |
sschuberth
reviewed
Oct 10, 2024
Juli0q
force-pushed
the
fossid-configurable-sensitivity
branch
3 times, most recently
from
92ebe20
to
d6f76bc
Compare
Add the option for the user to specify the sensitivity for a FossID scan to reduce the number of pending identifications. Signed-off-by: Julian Olderdissen <julian.olderdissen@bosch.com>
Juli0q
force-pushed
the
fossid-configurable-sensitivity
branch
from
d6f76bc
to
9153fe3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the option for the User to specify the sensitivity for a FossID Scan to reduce the number of pending identifications.