test: Ensure to use a compatible Java version for Gradle projects #9262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fixup for e34734a to also handle "legacy" Gradle tests. It is unclear why this was not required earlier by CI: Probably due to some caching, which got invalidated with CI's upgrade to Ubuntu 24.04. Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9262 +/- ##
=========================================
Coverage 67.67% 67.67%
Complexity 1187 1187
=========================================
Files 239 239
Lines 7796 7796
Branches 900 900
=========================================
Hits 5276 5276
Misses 2153 2153
Partials 367 367
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fviernau
reviewed
Oct 9, 2024
| @@ -33,7 +33,8 @@ class GradleAndroidFunTest : StringSpec({ | |||
| val definitionFile = getAssetFile("projects/synthetic/gradle-android/build.gradle") | |||
| val expectedResultFile = getAssetFile("projects/synthetic/gradle-android-expected-output-root.yml") | |||
|
|
|||
| val result = create("Gradle").resolveSingleProject(definitionFile, resolveScopes = true) | |||
| val result = create("Gradle", "javaVersion" to "17") | |||
There was a problem hiding this comment.
Should we factor out createGradle() so these can be kept one-liners ?
There was a problem hiding this comment.
I have a slight preference for seeing the configuration explicitly in each test, as Java requirements might change on a per-test basis. Also, I'd like to keep this aligned with the respective GI tests as much as possible for now.
fviernau
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fixup for e34734a to also handle "legacy" Gradle tests. It is unclear why this was not required earlier by CI: Probably due to some caching, which got invalidated with CI's upgrade to Ubuntu 24.04.