chore(model): Avoid a Hoplite deprecation warning #9283
Conversation
This avoids the console output of: "Hoplite is configured to infer which sealed type to choose by inspecting the config values at runtime. This behaviour is now deprecated in favour of explicitly specifying the type through a discriminator field. In 3.0 this new behavior will become the default. To enable this behavior now (and disable this warning), invoke withExplicitSealedTypes() on the ConfigLoaderBuilder." Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
|
This change causes
when deserializing |
| @@ -174,6 +176,7 @@ data class OrtConfiguration( | |||
| .addEnvironmentSource() | |||
| .addPropertySources(sources) | |||
| .withContextResolverMode(ContextResolverMode.SkipUnresolved) | |||
| .withExplicitSealedTypes() | |||
There was a problem hiding this comment.
I think the ScanStorageConfiguration is the only sealed class we use in the config, but I don't think that we use discriminator fields there. I'm not sure if this is properly tested.
No, we should not introduce this in the config. I think we have to wait until I finally find time for #6603. |
This avoids the console output of:
"Hoplite is configured to infer which sealed type to choose by inspecting the config values at runtime. This behaviour is now deprecated in favour of explicitly specifying the type through a discriminator field. In 3.0 this new behavior will become the default. To enable this behavior now (and disable this warning), invoke withExplicitSealedTypes() on the ConfigLoaderBuilder."