feat(vcs): Add Git-specific configuration options for submodule handling #9721
+78
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wkl3nk, please try if this still works as expected for you. |
sschuberth
force-pushed
the
wkl3nk/add-configuration-options-for-git
branch
3 times, most recently
from
22340e0 to
522e3c8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9721 +/- ##
============================================
+ Coverage 68.07% 68.09% +0.02%
Complexity 1294 1294
============================================
Files 250 249 -1
Lines 8849 8846 -3
Branches 923 923
============================================
Hits 6024 6024
+ Misses 2436 2433 -3
Partials 389 389
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sschuberth
force-pushed
the
wkl3nk/add-configuration-options-for-git
branch
2 times, most recently
from
bd922d2 to
bb96512
Compare
There was a problem hiding this comment.
Looks good to me, @sschuberth do you want to wait for feedback from @wkl3nk?
Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
Defaults for individual properties are usually applied as part of `parseConfig()` implementations. Add default arguments to `create()` to avoid constructs like `create(parseConfig(emptyMap(), emptyMap()))`. Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
…e yet This is a fixup for debbc8d. Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
Use `PluginConfiguration` instead of `VersionControlSystemConfiguration`. This is a fixup for debbc8d. Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
sschuberth
force-pushed
the
wkl3nk/add-configuration-options-for-git
branch
from
bb96512 to
e4b94b1
Compare
Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
For large repositories with many layers of nested Git submodules, the checkout process can be very time-consuming and often results in duplicate projects in the tree of nested submodules. This feature introduces configuration options to limit the recursive checkout of nested Git submodules to the first layer, optimizing performance and reducing redundancy. Additionally, it also allows to limit the depth of the commit history when checking out the projects. Signed-off-by: Wolfgang Klenk <wolfgang.klenk2@bosch.com> Signed-off-by: Sebastian Schuberth <sebastian@doubleopen.org>
sschuberth
force-pushed
the
wkl3nk/add-configuration-options-for-git
branch
from
e4b94b1 to
5699075
Compare
I'd appreciate getting an approval to be able to merge any time. I'll probably wait time-boxed for feedback from @wkl3nk until some time mid-Monday, but then I'd like to get this off my plate. |
|
@sschuberth Thanks again for pushing this forward. Yes, the recent changes will also work out for me. |
fviernau
requested changes
Jan 13, 2025
mnonnenmacher
approved these changes
Jan 13, 2025
fviernau
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at the individual commit messages for the details.