Skip to content

Added back support for CLI parameters. #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 17, 2025
Merged

Added back support for CLI parameters. #22

merged 4 commits into from
Jan 17, 2025

Conversation

lsphillips
Copy link
Contributor

@lsphillips lsphillips commented Jan 16, 2025

As part of #7, param variables were added back into this fork as this functionality was removed due to it being part of @serverless/dashboard-plugin. However that PR only added back support for variables defined as stage variables in the serverless.yml configuration, not as CLI arguments.

This PR adds back support for passing param variables as CLI arguments.

Copy link
Contributor

@robhughadams robhughadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 😃 There's a tiny typo in a test description I spotted.

lsphillips and others added 3 commits January 17, 2025 11:09
Co-authored-by: Robert Adams <robhughadams@hotmail.com>
@mnapoli
Copy link
Contributor

mnapoli commented Jan 17, 2025

Thanks!

@mnapoli mnapoli merged commit 496ec52 into oss-serverless:main Jan 17, 2025
3 checks passed
@lsphillips lsphillips deleted the add-back-cli-params branch January 17, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants