Skip to content

Add ability to set a description for a HttpApi #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 7, 2025

Conversation

j0k3r
Copy link
Contributor

@j0k3r j0k3r commented Mar 7, 2025

Title says it all.
If the description isn't provided, nothing will change.

I've add doc about it (and about name too).

I've also removed an extra level for titles below Shared Authorizer because it's doesn't seems to be ok (titles below it aren't related to authorizer at all)

See the diff

From:
image

To:
image

Also commented two lines in services.js because these variables aren't used and are reported when running ESLint:

   9:7  error  'currentVersion' is assigned a value but never used      no-unused-vars
  10:7  error  'isLocallyInstalled' is assigned a value but never used  no-unused-vars

Related to ae66e20

j0k3r added 2 commits March 7, 2025 11:41
Also comment two lines in `services.js` because these variables aren't used and are reported when running ESLint:

```
   9:7  error  'currentVersion' is assigned a value but never used      no-unused-vars
  10:7  error  'isLocallyInstalled' is assigned a value but never used  no-unused-vars
```
@mnapoli
Copy link
Contributor

mnapoli commented Mar 7, 2025

Thanks!

@mnapoli mnapoli merged commit 0dc5518 into oss-serverless:main Mar 7, 2025
3 checks passed
@j0k3r j0k3r deleted the feature/http-api-description branch March 7, 2025 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants