Playbook #73
Merged
Playbook #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 17 commits
November 1, 2023 09:36
…ommunity training
kungfuchicken
previously approved these changes
May 29, 2024
Collaborator
kungfuchicken
left a comment
kungfuchicken
left a comment
There was a problem hiding this comment.
lgtm; i'd like to get it merged and keep working on it in smaller chunks.
Collaborator
|
it's blocking merge b/c i pushed commits to it. I'm okay with bypassing merge requirements once we've both looked at it, or we could have @rkarmuri give it a review. |
Contributor
Author
|
@kungfuchicken Your commit 3b69903 removed the changes you added in commit ae10cfa. Was that intentional? |
Collaborator
|
this is one of myriad reasons extra eyes are always good. probably bungled this when trying to do a line-by-line (instead of whole file) commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Playbook for creating an open source program office at a university - the SLU way.