Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor nbtsort-xx.c #110

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yanmeisun
Copy link
Contributor

In issues #106, nbtsort-xx.c was suggested to be refactored as follow:

  • If there are functions for only pg_bulkload in "lib/nbtree/nbtsort-XX.c", move the functions to "lib/nbtree/nbtsort-common.c"
  • Copy PostgreSQL's latest stable "src/backend/access/nbtree/nbtsort.c" to "lib/nbtree/nbtsort-XX.c"

This PR does it. However PostgreSQL version under 9.5 has been EOL, refactoring wasn't done between nbtsort-8.3.c ~ nbtsort-9.5.c.

@mikecaat
Copy link
Contributor

mikecaat commented Aug 2, 2021

Hi,

Thanks for your works.

Copy PostgreSQL's latest stable "src/backend/access/nbtree/nbtsort.c" to "lib/nbtree/nbtsort-XX.c"

On the second thought, are just to remove nbtsort-XX.cc and to include "access/nbtree.h" enough?
To copy is redundant and it seems to have no advantage. If we use include "access/nbtree.h",
I think there is an advantage that we don't need to care minor (and major?) version up.

Sorry for changing my first suggestion. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants