Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPExist function available but never used leading to duplicated IPs with authd #1509

Open
tanderson3 opened this issue Aug 27, 2018 · 5 comments

Comments

@tanderson3
Copy link

In PR#1161 - we can see that the function IPExist has been set back:
#1161

But this function is never used and it's still possible to duplicate IPs using the authd mechanism.
It had been enabled in that patch:
https://github.com/ossec/ossec-hids/pull/1162/files#diff-c1d16a58d2ed41485e829b7ff16b2ecfR495
Then removed with this patch:
352e740

Would it be possible to re-enable that feature since the function seems to come back in code?

@tanderson3
Copy link
Author

Any plan to get that "IP duplicate check" function back in a next release?

ddpbsd added a commit to ddpbsd/ossec-hids that referenced this issue Dec 19, 2018
Lightly tested, seemed to work.
Issue ossec#1509
@ddpbsd
Copy link
Member

ddpbsd commented Dec 19, 2018

Please test pull request #1603

@tanderson3
Copy link
Author

Sounds like it's working with that fix now. Thanks!
Do you think this could be merged anytime soon?

@ddpbsd
Copy link
Member

ddpbsd commented Dec 20, 2018

I think @atomicturtle is planning on a new release in January, but don't quote me on that.

@tanderson3
Copy link
Author

Ok, nice. Thanks Dan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants