Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check_rc_pids's check condition #1514

Open
ggWithZhou opened this issue Aug 30, 2018 · 1 comment
Open

check_rc_pids's check condition #1514

ggWithZhou opened this issue Aug 30, 2018 · 1 comment

Comments

@ggWithZhou
Copy link

line 232 of check_rc_pids.c:
if (! (_kill0 == 1 && _gsid0 == 0 && _gpid0 == 0 && _gsid1 == 0) )
The prerequisite for this step is _gsid0 == _gsid1, so _gsid1 == 0 is redundant. And this problem is not important. There is another problem:
line 245:
if (! (_kill1 == 1 && _gsid1 == 0 && _gpid0 == 0 && _gsid1 == 0) )
_gsid1 == 0 appears twice. Is that a redundancy or it should be _gsid0 == 0 && _gsid1 ==0?
ddpbsd added a commit to ddpbsd/ossec-hids that referenced this issue Aug 30, 2018
@ddpbsd
From issue ossec#1514, a duplicate _gsid1 == 0 -> _gsid0 == 0
3ea18dd 
Reported by ggWithZhou
@ddpbsd
Copy link
Member

ddpbsd commented Aug 30, 2018

Looks like a typo to me. I submitted pull request #1515

atomicturtle added a commit that referenced this issue Aug 30, 2018
@atomicturtle
Merge pull request #1515 from ddpbsd/1514_rootcheck
c7050e6 
From issue #1514, a duplicate `_gsid1 == 0` -> `_gsid0 == 0`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ddpbsd @ggWithZhou