Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling #1235

Merged
merged 60 commits into from
Aug 30, 2017
Merged

Spelling #1235

merged 60 commits into from
Aug 30, 2017

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Aug 29, 2017

fwiw, this is a subset of wazuh/wazuh#171

@ddpbsd
Copy link
Member

ddpbsd commented Aug 29, 2017

I don't like changing groupping at the moment, for backwards compatibility reasons. Everything else I saw looked good though

@jsoref
Copy link
Contributor Author

jsoref commented Aug 29, 2017

Dropped

@atomicturtle
Copy link
Member

Ha, this is fantastic. I wonder how many of those were my fault :P

@jsoref
Copy link
Contributor Author

jsoref commented Aug 29, 2017

fwiw, this is more or less about average for spelling errors in a project. (I haven't actually generated a metric for this, but someone could easily build one by reviewing the PRs I've made against dozens of projects...)

@ddpbsd
Copy link
Member

ddpbsd commented Aug 30, 2017

Thanks for going through all of those!

@ddpbsd ddpbsd merged commit b8f855c into ossec:master Aug 30, 2017
@jsoref jsoref deleted the spelling branch August 30, 2017 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants