Remove unnecessary echo for duplicated entry #1552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This logging for duplicated entries is already covered by an echo some lines below for the "add" case:
ossec-hids/active-response/host-deny.sh
Line 109 in 0125b4f
Keeping this echo will cause a log entry for the "delete" case which is completely unnecessary because it is clear that an entry already exists in the hosts.deny.
Also moved the check for duplicated entries after the IP syntax verification as we only need to check for duplicated entries if we have verified that we really got an IP.
Furthermore replaced the tabs with spaces and stripped down the comment.