Allow installation as unpriv user #1599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From @mobstef in issue ossec#1570: "The FreeBSD build servers create binary packages from ports as non-root user. It is therefore essential, that the Makefile allows installation as non-root user too. The problem with current Makefile is that it explicitly references "root" user and "0" group. Additionally it sets permission on certain directories to 550 and later writes to them, which is possible by root, but not as an unprivileged user. The best solution I came up with is to replace every invocation of "install" command by a macro, that by default sets mode and ownership of files as it used to be ("INSTALL_CMD"). If anybody needs to skip permission and ownership setting, he just need to set "INSTALL_CMD=install"."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taken directly from issue #1570
Should help packagers.
This could use more testing, but it worked in the few things I tried.