Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some coverity issues #1616

Merged
merged 9 commits into from
Dec 31, 2018
Merged

Fix some coverity issues #1616

merged 9 commits into from
Dec 31, 2018

Commits on Dec 31, 2018

  1. Try to make sure the string can be NUL terminated.

    @ddpbsd
    ddpbsd committed Dec 31, 2018
    Configuration menu
    Copy the full SHA
    cb8c1aa View commit details
    Browse the repository at this point in the history

  2. string[strlen(hostname)] has no room for a NUL terminator.

    @ddpbsd
    ddpbsd committed Dec 31, 2018
    Configuration menu
    Copy the full SHA
    d19f670 View commit details
    Browse the repository at this point in the history

  3. Another NUL termination. 

    I'll batch these from now on.
    @ddpbsd
    ddpbsd committed Dec 31, 2018
    Configuration menu
    Copy the full SHA
    a75453c View commit details
    Browse the repository at this point in the history

  4. More string lengths. 

    lf->mon needs to be checked differently than other things apparently.
    @ddpbsd
    ddpbsd committed Dec 31, 2018
    Configuration menu
    Copy the full SHA
    8ce9fb0 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' of github.com:ddpbsd/ossec-hids into 20181231_c… 

    …overity
    @ddpbsd
    ddpbsd committed Dec 31, 2018
    Configuration menu
    Copy the full SHA
    80f6132 View commit details
    Browse the repository at this point in the history

  6. More array comparison changes

    @ddpbsd
    ddpbsd committed Dec 31, 2018
    Configuration menu
    Copy the full SHA
    e5690ae View commit details
    Browse the repository at this point in the history

  7. Match the formatting of the other if statements. 

    I think these commits cover coverity IDs:
185357,185356,185355,185354,185353,185352,185351
    @ddpbsd
    ddpbsd committed Dec 31, 2018
    Configuration menu
    Copy the full SHA
    61dd709 View commit details
    Browse the repository at this point in the history

  8. Oops, a bit over zealous there.

    @ddpbsd
    ddpbsd committed Dec 31, 2018
    Configuration menu
    Copy the full SHA
    2bd8042 View commit details
    Browse the repository at this point in the history

  9. white space

    @ddpbsd
    ddpbsd committed Dec 31, 2018
    Configuration menu
    Copy the full SHA
    ebb5a0b View commit details
    Browse the repository at this point in the history