Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support arm64 packaging #1809

Merged
merged 6 commits into from
Jun 17, 2020
Merged

Support arm64 packaging #1809

merged 6 commits into from
Jun 17, 2020

Conversation

nurse
Copy link
Contributor

@nurse nurse commented Jan 9, 2020

Though this PR is some rough points, this successfully create a deb package for arm64.
I want to merge this PR but I noticed current generate_ossec.sh doesn't work well now.
So before I blush up this I ask you how to improve this PR.

fix #1073

# setup gnupg key in ~/.gnupg
# write passphrase of gnupg key in ~/.gnupg/passphrase
# Update `signing_key` in contrib/debian-packages/generate_ossec_xenial_arm64.sh
docker build -t ossec-hids-agent .
docker run --rm -it --privileged -v$HOME/.gnupg:/root/.gnupg ossec-hids-agent /bin/bash
/home/ubuntu/ossec-hids/contrib/debian-packages/generate_ossec_xenial_arm64.sh -a
# results are in /var/cache/pbuilder/xenial-arm64/result/

@nurse nurse mentioned this pull request Jan 9, 2020
@atomicturtle
Copy link
Member

This is fantastic, Id love to get packages for this added into the repo. Let me know if you want a slack invite (slack@ossec.net) if you want to coordinate!

@atomicturtle
Copy link
Member

I have some changes that will address issues #1810 and #1807 that Id like to do after your commit is in so I can capture it on both. Let us know when you're done with your update!

@nurse nurse force-pushed the xenial-arm64 branch 2 times, most recently from 12f7d70 to 5922232 Compare January 18, 2020 12:06
@nurse
Copy link
Contributor Author

nurse commented Jan 19, 2020

Thanks! I mailed to request an invitation.

Also I updated my PR to add Dockerfile to provide more reproducible example.

@nurse
Copy link
Contributor Author

nurse commented Jan 23, 2020

@atomicturtle Hi,
I sent a mail but no response now. Could you check it?
thanks,

@zfouts
Copy link

zfouts commented Jun 15, 2020

Hi @atomicturtle - hope you're doing well :) I work with @nurse and I was curious if you had a chance to move forward with this. It's not currently a blocker as we can host the packages ourselves to move forward, but we're hoping to help others out in the community :) Thanks for your time!

@atomicturtle
Copy link
Member

Sure, this is still marked as a Draft pull request on your side so I cant merge it from here. @nurse would need to change that setting, and then we can push this into main. I dont have any other changes otherwise (we already added the arm64 packages to the repo)

@atomicturtle atomicturtle marked this pull request as ready for review June 16, 2020 13:03
@nurse
Copy link
Contributor Author

nurse commented Jun 17, 2020

It says "CI build failed" but actually on travis it successfully ran.
https://travis-ci.org/github/ossec/ossec-hids/builds/698913107
Or manually re-runed?

@atomicturtle atomicturtle merged commit f3c5a6a into ossec:master Jun 17, 2020
@nurse nurse deleted the xenial-arm64 branch June 18, 2020 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Packages for ARM machines
3 participants