fix openssl operations on non blocking socket #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have no seen any reports of errors of this type, but this code is much cleaner and simpler to follow. Plus the error handling is makes sense now 👍 Testing: I am not seeing an issue with 1000 key requests. I have not hooked it it up to valgrind, but that is not gonna tell me any issues with this pull request (just all other ossec memory issue we need to work on). Thank you @gaelmuller |
jrossi
added a commit
that referenced
this pull request
Jan 31, 2014
fix openssl operations on non blocking socket
cgzones
added a commit
that referenced
this pull request
Feb 6, 2015
ddpbsd
pushed a commit
that referenced
this pull request
Sep 29, 2015
Include TS Gateway Events in msauth_rules.xml
ddpbsd
pushed a commit
to ddpbsd/ossec-hids
that referenced
this pull request
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having problems with ossec-authd (SSL Accept error + SSL Read error). This was due to incorrect error handling for these two operations in the context of non blocking sockets (which is the case for the ossec-authd server).
I don't know what I seem to be the only one to experience this issue (maybe my LAN is particularly slow ... :/)
The diff contains a lot of noise because I removed a if/else construct, and then reindented a big block of code.
Orgianl Pull Request: https://bitbucket.org/jbcheng/ossec-hids/pull-request/26/fix-openssl-operations-on-non-blocking/diff
@gaelmuller