[photon-os] Adds ecosystem and prefix for Photon #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbloom7
reviewed
Jan 5, 2023
|
Q: Any preference between |
We typically go with the casing that's canonical for that ecosystem. Perhaps "Photon OS" is the best and unambiguous one? |
|
@captn3m0 friendly ping :) |
|
Thanks for the ping - need to fix a few more issues alongside in the advisories. Will update here soon. |
|
This should be good to merge now. I've made a lot of changes to the code to ensure correctness (better tracking |
oliverchang
reviewed
Jul 3, 2023
Signed-off-by: Nemo <commits@captnemo.in>
oliverchang
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #105 earlier. I'm also using the ecosystem field in existing advisories: https://github.com/captn3m0/photon-os-advisories/blob/main/advisories/PHSA-2016-0006.json
Advisories are already published in OSV format: https://github.com/captn3m0/photon-os-advisories/tree/main/advisories (And Automated).
I'll get those enriched over time, but this could be merged in the interim.
Signed-off-by: Nemo commits@captnemo.in