Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami] Adds ecosystem and prefix for Bitnami #156

Merged
merged 3 commits into from
Jun 13, 2023

Conversation

gongomgra
Copy link
Contributor

@gongomgra gongomgra commented May 25, 2023

We are in the process of creating/publishing our own CVE feed based on OSV schema for the Bitnami catalog, but we would like to start the review process for a Bitnami ecosystem key. Do not hesitate to ask any questions you may have.

Signed-off-by: Gonzalo Gomez Gracia <gonzalog@vmware.com>
Copy link
Contributor

@oliverchang oliverchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! Thanks for this contribution. I just have some questions.

@@ -527,6 +538,7 @@ The defined ecosystems are:
| `ConanCenter` | The ConanCenter ecosystem for C and C++; the `name` field is a Conan package name. |
| `Rocky Linux` | The Rocky Linux package ecosystem; the `name` is the name of the source package. The ecosystem string might optionally have a `:<RELEASE>` suffix to scope the package to a particular Rocky Linux release. `<RELEASE>` is a numeric version.
| `AlmaLinux` | AlmaLinux package ecosystem; the `name` is the name of the source package. The ecosystem string might optionally have a `:<RELEASE>` suffix to scope the package to a particular AlmaLinux release. `<RELEASE>` is a numeric version.
| `Bitnami` | Bitnami package ecosystem; the `name` is the name of the affected component. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there documentation or additional rules around the naming for a "component" ?

Copy link
Contributor Author

@gongomgra gongomgra May 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have any special rule for naming our components, apart from using lowercase and dashes as separators (i.e. wordpress-multisite). We also publish the official URL of those packages in our Dockerfiles on GitHub.

https://downloads.bitnami.com/files/stacksmith/${COMPONENT}.tar.gz

Additionally, we provide purl for those packages like pkg:bitnami/wordpress@6.2.2.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, thanks!

docs/schema.md Outdated
@@ -286,6 +286,17 @@ The defined database prefixes and their "home" databases are:
</ul>
</td>
</tr>
<tr>
<td><code>BITNAMI</code></td>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these advisories come with their own IDs? If so, we can document them under https://ossf.github.io/osv-schema/#id-modified-fields.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had to open a few CVEs in the past, but we don't have a specific identifier like RHSA or similar, so I will remove this from the PR. Thank you for checking!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for my slightly confusing original comment. Nothing having a specific identifier does make things a bit more complicated within the OSV ecosystem, since if you use e.g. CVEs as the ID directly it's hard to disambiguate advisories.

Do you have any existing examples of any Bitnami-specific advisories? It may be very worthwhile to have a specific identifier for the Bitnami-specific advisories so that it's clear exactly where it comes from and what it's specific to.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only had to register CVEs for specific Bitnami products a few times in the past. And for those we filled a regular CVE on NVD.

As we are distributing open source programs like WordPress or Redmine as provided from upstream projects (no modification to source code, just easy way to consume), we understand a custom BITNAMI-2023-0001 ID doesn't make much sense for our specific use case. Can you help us to clarify this point?

Copy link
Contributor

@oliverchang oliverchang Jun 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify, I'm suggesting that Bitnami does have its own ID namespace, to have more ownership over the Bitnami-specific bits. Even if you don't modify source code etc, there may still be interesting additional context through textual descriptions, or different severities. A cheap way to get a custom ID namespace is to just prefix CVEs with BITNAMI or something similar. e.g. BITNAMI-CVE-XXXX-XXX.

If this doesn't work for you, that's OK and we can just go with CVEs. I'll merge this as-is in that case.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a consumer it really does make it easier to get distinct identifiers, it would be appreciated!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oliverchang Thanks for your message, I really appreciate the clarification. Let me check it with the team and get back to you.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oliverchang we are thinking on moving to BIT-XXXX-XXXX. Would that work for you? We could have it ready in some days.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, absolutely! Please add that ID section back to document this :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @oliverchang,

I have just recovered the section for BIT prefix instead of BITNAMI as we have agreed. Let me know if there is anything else I may update.

Signed-off-by: Gonzalo Gomez Gracia <gonzalog@vmware.com>
Signed-off-by: Gonzalo Gomez Gracia <gonzalog@vmware.com>
Copy link
Contributor

@oliverchang oliverchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@oliverchang oliverchang merged commit 8ea393a into ossf:main Jun 13, 2023
@gongomgra gongomgra deleted the bitnami-prefix-and-ecosystem branch June 13, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants