Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added SUSE and openSUSE #260

Merged
merged 2 commits into from
Sep 3, 2024
Merged

added SUSE and openSUSE #260

merged 2 commits into from
Sep 3, 2024

Conversation

msmeissn
Copy link
Contributor

Added the SUSE and openSUSE ecosystem.

#259

Copy link
Contributor

@oliverchang oliverchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thank you!

docs/schema.md Show resolved Hide resolved
validation/schema.json Show resolved Hide resolved
docs/schema.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@andrewpollock andrewpollock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some minor style and grammar

docs/schema.md Outdated Show resolved Hide resolved
Copy link
Contributor

@oliverchang oliverchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

docs/schema.md Outdated
@@ -685,13 +696,15 @@ The defined ecosystems are:
| `npm` | The NPM ecosystem; the `name` field is an NPM package name. |
| `NuGet` | The NuGet package ecosystem. The `name` field is a NuGet package name. |
| `OSS-Fuzz` | For reports from the OSS-Fuzz project that have no more appropriate ecosystem; the `name` field is the name assigned by the OSS-Fuzz project, as recorded in the submitted fuzzing configuration. |
| `openSUSE` | The openSUSE ecosystem; The ecosystem specifier is the marketing name of the openSUSE distribution. With the `:` removed, it matches the value in the /etc/os-release `PRETTY_NAME` field. The `name` field is the name of the source RPM and accompanied by a purl. There is a `ecosystem_specific` specific array `binaries` of the associated RPM binary packages in this specific openSUSE distribution. The ECOSYSTEM version ordering is the RPM versioncompare ordering, and the database uses the `introduced` and `fixed` boundaries.|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `openSUSE` | The openSUSE ecosystem; The ecosystem specifier is the marketing name of the openSUSE distribution. With the `:` removed, it matches the value in the /etc/os-release `PRETTY_NAME` field. The `name` field is the name of the source RPM and accompanied by a purl. There is a `ecosystem_specific` specific array `binaries` of the associated RPM binary packages in this specific openSUSE distribution. The ECOSYSTEM version ordering is the RPM versioncompare ordering, and the database uses the `introduced` and `fixed` boundaries.|
| `openSUSE` | The openSUSE ecosystem; The ecosystem string has a `:<RELEASE>` suffix representing the marketing name of the openSUSE distribution. `<RELEASE>` matches the value in the /etc/os-release `PRETTY_NAME` field. The `name` field is the name of the source RPM and accompanied by a purl. There is a `ecosystem_specific` specific array `binaries` of the associated RPM binary packages in this specific openSUSE distribution. The ECOSYSTEM version ordering is the RPM versioncompare ordering, and the database uses the `introduced` and `fixed` boundaries.|

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(One more suggestion for consistency with other ecosystem definitions)

docs/schema.md Outdated Show resolved Hide resolved
Added the SUSE and openSUSE ecosystem.

ossf#259

Co-authored-by: Andrew Pollock <andrewpollock@users.noreply.github.com>
Signed-off-by: Marcus Meissner <meissner@suse.de>
@msmeissn
Copy link
Contributor Author

Thanks. I had to resolve conflicts with the last ubuntu change, and squashed.

I also changed the wording again a bit, as we have "SUSE:Linux Enterprise Server" ... so the prefix includes part of the marketing name.

Copy link
Contributor

@oliverchang oliverchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! Just one last comment.

docs/schema.md Outdated Show resolved Hide resolved
@oliverchang oliverchang merged commit 990d7f4 into ossf:main Sep 3, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants