Add Kafka support for scheduler #77
Merged
+180
−131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverchang
reviewed
May 27, 2021
scheduler/proxy/proxy.go
Outdated
| msg, err := proxy.subscription.Receive(ctx) | ||
| if err != nil { | ||
| log.Println("error receiving message: ", err) | ||
| continue |
There was a problem hiding this comment.
This is a problem that existed prior to your PR as well, but if Receive gets an error, it'll never succeed again per: https://pkg.go.dev/gocloud.dev/pubsub#Subscription.Receive
We need to either return here or recreate the subscription before retrying.
There was a problem hiding this comment.
I've returned here to avoid the application hanging with a broken Subscription, going forwards we should look to reconstruct the Subscription before retrying as you mention.
Qinusty
force-pushed
the
qinusty/kafka-support
branch
from
c506734 to
ed7d819
Compare
|
Part of the issue #70 |
oliverchang
approved these changes
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces kafka support for scheduler and simplifies logic away from scheduler/main.go.
Additionally the dependency on
github.com/jordan-wright/ossmalwareis replaced withgithub.com/ossf/package-feedsfor thePackagestruct definition.The
package-feedsdependency introduces the updated struct in relation to #48.Additional kafka support will need to be added for the analysis workers. Also we probably want to consider the range implementations of pubsub supported by gocloud as these will need to be imported.