feeds/scheduler/feed_group.go: Handle per package errs when publishing #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tom--pollard
force-pushed
the
handle_per_pub_err
branch
2 times, most recently
from
4a9f736 to
7fdb48e
Compare
tom--pollard
commented
Jun 11, 2021
Qinusty
approved these changes
Jun 15, 2021
tom--pollard
force-pushed
the
handle_per_pub_err
branch
2 times, most recently
from
6c8e8f3 to
5e3ed46
Compare
publishPackages() no longer immediately returns if a single package fails to be marshalled or sent to the publisher. Instead the error is logged and a generic `errPub` is returned, inline with poll().
tom--pollard
force-pushed
the
handle_per_pub_err
branch
from
5e3ed46 to
4fb53ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
publishPackages() no longer immediately returns if a single package
fails to be marshalled or sent to the publisher. Instead the error
is logged and a generic
errPubis returned, inline with poll().This is for #101, however it could be extended in the future with retry logic, or even some form of
event.