Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune NPM timeouts and behavior for http2 #339

Merged
merged 3 commits into from
May 11, 2023
Merged

Tune NPM timeouts and behavior for http2 #339

merged 3 commits into from
May 11, 2023

Conversation

calebbrown
Copy link
Contributor

#337

Tweak the behavior of NPM to work better with HTTP2 to reduce timeouts.

Signed-off-by: Caleb Brown <calebbrown@google.com>
@calebbrown calebbrown requested a review from maxfisher-g May 11, 2023 04:58
Signed-off-by: Caleb Brown <calebbrown@google.com>
maxfisher-g
maxfisher-g previously approved these changes May 11, 2023
Copy link
Contributor

@maxfisher-g maxfisher-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion, otherwise LGTM

pkg/feeds/npm/npm.go Outdated Show resolved Hide resolved
Signed-off-by: Caleb Brown <calebbrown@google.com>
@calebbrown calebbrown merged commit 0922729 into main May 11, 2023
@calebbrown calebbrown deleted the http2_tuning branch May 11, 2023 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants