Add an LRU cache for NPM responses to reduce HTTP traffic. #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Caleb Brown <calebbrown@google.com>
Signed-off-by: Caleb Brown <calebbrown@google.com>
maxfisher-g
reviewed
Jun 28, 2023
maxfisher-g
reviewed
Jun 28, 2023
maxfisher-g
previously approved these changes
Jun 28, 2023
|
Looks good, just a little more documentation would be good for future code readers |
Signed-off-by: Caleb Brown <calebbrown@google.com>
maxfisher-g
approved these changes
Jun 29, 2023
|
Thanks for the changes! Those are awesome comments :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces an LRU cache for NPM responses to avoid needless HTTP traffic for duplicate queries.
The hope is to improve the reliability of NPM requests by reusing cached data using the ETag in an "If-None-Match" header.
#337