Add basic cron based 'timer' mode #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tom--pollard
force-pushed
the
internal_scheduler
branch
2 times, most recently
from
29af94e to
3f756ac
Compare
tom--pollard
force-pushed
the
internal_scheduler
branch
from
3f756ac to
ea7570c
Compare
Qinusty
reviewed
Apr 16, 2021
tom--pollard
force-pushed
the
internal_scheduler
branch
from
ea7570c to
c5fb6a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This leverages the
cutoff_deltaconfig, adding the option to set an internalcronlike scheduler for triggering the polling of feeds. The current implementation somewhat mimics the current trigger which is driven by requests from an external scheduled service.As mentioned in #85 this is one approach that uses a static frequency, this could be expanded to be dynamic (storing an internal value for
time_of_last_poll, to use for thecuttoffthreshold instead potentially on a per feed basis). Further to that is the consideration of if a httpserver should even be launched in thisstandalonemode, or even a hybrid approach. These can all be considered in followup PRs