Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poll directly when running internal timer requests #98

Merged
merged 2 commits into from
May 6, 2021

Conversation

tom--pollard
Copy link
Contributor

@tom--pollard tom--pollard commented Apr 29, 2021

This is currently based on #94

This should resolve #95 by not relying on http requests to the localserver, and is extra progress towards #85

@tom--pollard tom--pollard force-pushed the direct_timer branch 3 times, most recently from 7e9358c to 5aadcba Compare April 30, 2021 13:15
@tom--pollard tom--pollard changed the title WIP: Poll directly when running internal timer requests Poll directly when running internal timer requests Apr 30, 2021
Copy link
Contributor

@Qinusty Qinusty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some thoughts, looks good though!

cmd/scheduled-feed/main.go Outdated Show resolved Hide resolved
cmd/scheduled-feed/main.go Show resolved Hide resolved
cmd/scheduled-feed/main.go Show resolved Hide resolved
cmd/scheduled-feed/main.go Show resolved Hide resolved
Copy link
Contributor

@Qinusty Qinusty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :) We can address those minor raised issues separately

@tom--pollard tom--pollard merged commit 26d0b4d into ossf:main May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tweak http response handling in cronrequest()
2 participants