Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Get repo info from REST API if event file is unavailable #576

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

azeemshaikh38
Copy link
Contributor

Part of #156. See #156 (comment). This PR:

  • Fixes the breakages for scheduled trigger.
  • Ensures that the default value of publish_results is false.

@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #576 (cbcc97c) into main (85bc05a) will decrease coverage by 0.94%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #576      +/-   ##
==========================================
- Coverage   63.94%   62.99%   -0.95%     
==========================================
  Files           4        4              
  Lines         208      227      +19     
==========================================
+ Hits          133      143      +10     
- Misses         66       72       +6     
- Partials        9       12       +3     
Impacted Files Coverage Δ
options/env.go 100.00% <ø> (ø)
options/options.go 83.82% <75.00%> (-5.07%) ⬇️

@azeemshaikh38 azeemshaikh38 merged commit 2e062bc into main Jun 27, 2022
@azeemshaikh38 azeemshaikh38 deleted the azeems/golang-bug branch June 27, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants