Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add contributing guide #85

Merged
merged 25 commits into from
Jun 26, 2024
Merged

add contributing guide #85

merged 25 commits into from
Jun 26, 2024

Conversation

UlisesGascon
Copy link
Member

Related #83

@UlisesGascon
docs: add contributing guide
8d4eae7 
Signed-off-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@UlisesGascon
docs: add code of conduct
b384fe1 
Signed-off-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@UlisesGascon UlisesGascon changed the title add CoC and contributing guide 📖 add CoC and contributing guide Jun 21, 2024
@UlisesGascon UlisesGascon marked this pull request as ready for review June 21, 2024 08:25
@UlisesGascon UlisesGascon added the documentation Improvements or additions to documentation label Jun 21, 2024
@UlisesGascon UlisesGascon mentioned this pull request Jun 21, 2024
Merged
lelia
lelia reviewed Jun 21, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
lelia
lelia reviewed Jun 21, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
lelia
lelia reviewed Jun 21, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
lelia
lelia reviewed Jun 21, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
lelia
lelia reviewed Jun 21, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
lelia
lelia reviewed Jun 21, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
lelia
lelia reviewed Jun 21, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
UlisesGascon and others added 7 commits June 22, 2024 13:14
@UlisesGascon @lelia
Update CONTRIBUTING.md
9c004e9 
Co-authored-by: lelia <le1ia@me.com>
Signed-off-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@UlisesGascon @lelia
Update CONTRIBUTING.md
34add7f 
Co-authored-by: lelia <le1ia@me.com>
Signed-off-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@UlisesGascon @lelia
Update CONTRIBUTING.md
dbaa1d7 
Co-authored-by: lelia <le1ia@me.com>
Signed-off-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@UlisesGascon @lelia
Update CONTRIBUTING.md
31c032f 
Co-authored-by: lelia <le1ia@me.com>
Signed-off-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@UlisesGascon @lelia
Update CONTRIBUTING.md
12b62e9 
Co-authored-by: lelia <le1ia@me.com>
Signed-off-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@UlisesGascon @lelia
Update CONTRIBUTING.md
679c28c 
Co-authored-by: lelia <le1ia@me.com>
Signed-off-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@UlisesGascon @lelia
Update CONTRIBUTING.md
4ef39a1 
Co-authored-by: lelia <le1ia@me.com>
Signed-off-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@UlisesGascon UlisesGascon requested a review from lelia June 22, 2024 11:23
lelia
lelia reviewed Jun 24, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
lelia
lelia reviewed Jun 24, 2024
View reviewed changes
CODE_OF_CONDUCT.md Outdated Show resolved Hide resolved
lelia
lelia suggested changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@lelia lelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@UlisesGascon — Changes LGTM! Just one more phrasing fix and a suggested update to the current Code of Conduct.

UlisesGascon and others added 2 commits June 25, 2024 07:24
@UlisesGascon @lelia
Update CONTRIBUTING.md
4ee6b2b 
Co-authored-by: lelia <le1ia@me.com>
Signed-off-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@UlisesGascon
docs: migrate to Contributor Covenant 2.1
f3706d5 
Signed-off-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@UlisesGascon UlisesGascon force-pushed the docs/improve-contributing-guide branch from 36f19d5 to f3706d5 Compare June 25, 2024 05:30
@UlisesGascon UlisesGascon requested a review from lelia June 25, 2024 05:31
lelia
lelia approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@lelia lelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@justaugustus justaugustus mentioned this pull request Jun 25, 2024
Open
justaugustus
justaugustus requested changes Jun 25, 2024
View reviewed changes
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good draft, @UlisesGascon, and thanks for the initial review pass, @lelia!
Left some comments on content and structure.

CODE_OF_CONDUCT.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@UlisesGascon UlisesGascon changed the title 📖 add CoC and contributing guide contributing guide Jun 26, 2024
@UlisesGascon UlisesGascon changed the title contributing guide add contributing guide Jun 26, 2024
@UlisesGascon
docs: removed project CoC
7cc7ce5 
Signed-off-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@UlisesGascon UlisesGascon force-pushed the docs/improve-contributing-guide branch from a853f45 to 7cc7ce5 Compare June 26, 2024 07:48
UlisesGascon and others added 8 commits June 26, 2024 09:50
@UlisesGascon
docs: update CoC link
3245d0e 
Signed-off-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@UlisesGascon @justaugustus
Update CONTRIBUTING.md
4d7e47e 
Co-authored-by: Stephen Augustus <justaugustus@users.noreply.github.com>
Signed-off-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@UlisesGascon @justaugustus
Update CONTRIBUTING.md
d73778e 
Co-authored-by: Stephen Augustus <justaugustus@users.noreply.github.com>
Signed-off-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@UlisesGascon @justaugustus
Update CONTRIBUTING.md
af8b2fe 
Co-authored-by: Stephen Augustus <justaugustus@users.noreply.github.com>
Signed-off-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@UlisesGascon @justaugustus
Update CONTRIBUTING.md
61fb8f9 
Co-authored-by: Stephen Augustus <justaugustus@users.noreply.github.com>
Signed-off-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@UlisesGascon @justaugustus
Update CONTRIBUTING.md
32b9558 
Co-authored-by: Stephen Augustus <justaugustus@users.noreply.github.com>
Signed-off-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@UlisesGascon
docs: move to tags
9b7101a
@UlisesGascon
Merge branch 'docs/improve-contributing-guide' of https://github.com/…
91f8bb9 
…UlisesGascon/openssf-scorecard-monitor into docs/improve-contributing-guide
@UlisesGascon UlisesGascon force-pushed the docs/improve-contributing-guide branch from 8d556b2 to 91f8bb9 Compare June 26, 2024 07:56
UlisesGascon and others added 4 commits June 26, 2024 09:58
@UlisesGascon @justaugustus
Update CONTRIBUTING.md
97a7fc1 
Co-authored-by: Stephen Augustus <justaugustus@users.noreply.github.com>
Signed-off-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@UlisesGascon @justaugustus
Update CONTRIBUTING.md
4af3db9 
Co-authored-by: Stephen Augustus <justaugustus@users.noreply.github.com>
Signed-off-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@UlisesGascon @justaugustus
Update CONTRIBUTING.md
b7069bf 
Co-authored-by: Stephen Augustus <justaugustus@users.noreply.github.com>
Signed-off-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@UlisesGascon
docs: split the release documentation
1aa027b 
Signed-off-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@UlisesGascon UlisesGascon force-pushed the docs/improve-contributing-guide branch from c45d38e to 1aa027b Compare June 26, 2024 08:01
@UlisesGascon
docs: restructure the content
d2068e4 
Signed-off-by: Ulises Gascón <ulisesgascongonzalez@gmail.com>
KoolTheba
KoolTheba approved these changes Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@KoolTheba KoolTheba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after all the changes! 🚀

justaugustus
justaugustus approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, @UlisesGascon!

@justaugustus justaugustus merged commit 93b107a into main Jun 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus justaugustus approved these changes

@lelia lelia lelia approved these changes

@KoolTheba KoolTheba KoolTheba approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@UlisesGascon @justaugustus @lelia @KoolTheba