⚠️ Update date formats and fields to RFC3339 (#2712)

- Update date format in multiple files from `YYYY-MM-DD` to `YYYY-MM-DDTHH:MM:SS-TZ`
- Update date from `2021-08-25` to `2023-03-02T10:30:43-06:00`
- Change date format from `2006-01-02` to `time.RFC3339`
- Add `time` import
- Update ScorecardResult

[pkg/testdata/check2.json]
- Change the date format from `YYYY-MM-DD` to `YYYY-MM-DDTHH:MM:SS-TZ`
[pkg/testdata/check1.json]
- Update date from `2021-08-25` to `2023-03-02T10:30:43-06:00`
[pkg/testdata/check3.json]
- Update the date field in `check3.json` from `2021-08-25` to `2023-03-02T10:30:43-06:00`
[pkg/testdata/check5.json]
- Update date in `check5.json` from 2021-08-25 to 2023-03-02T10:30:43-06:00
[pkg/json_test.go]
- Change date format from `2006-01-02` to `time.RFC3339`
- Update date from `2021-08-25` to `2023-03-02T10:30:43-06:00`
[pkg/testdata/check6.json]
- Change date from "2021-08-25" to "2023-03-02T10:30:43-06:00"
[pkg/json.go]
- Change the date format from "2006-01-02" to RFC3339
- Add "time" import
- Update the ScorecardResult struct to include the CommitSHA field
[pkg/testdata/check4.json]
- Update date from `2021-08-25` to `2023-03-02T10:30:43-06:00`
- Update commit from `68bc59901773ab4c051dfcea0cc4201a1567ab32`

Signed-off-by: naveensrinivasan <172697+naveensrinivasan@users.noreply.github.com>

pkg/json.go

@@ -18,6 +18,7 @@ import (
 	"encoding/json"
 	"fmt"
 	"io"
+	"time"
 
 	"github.com/ossf/scorecard/v4/checker"
 	docs "github.com/ossf/scorecard/v4/docs/checks"
@@ -163,7 +164,7 @@ func (r *ScorecardResult) AsJSON2(showDetails bool,
 			Version: r.Scorecard.Version,
 			Commit:  r.Scorecard.CommitSHA,
 		},
-		Date:           r.Date.Format("2006-01-02"),
+		Date:           r.Date.Format(time.RFC3339),
 		Metadata:       r.Metadata,
 		AggregateScore: jsonFloatScore(score),
 	}

pkg/json_test.go

@@ -73,7 +73,8 @@ func TestJSONOutput(t *testing.T) {
 	scorecardCommit := "ccbc59901773ab4c051dfcea0cc4201a1567abdd"
 	scorecardVersion := "1.2.3"
 	repoName := "org/name"
-	date, e := time.Parse("2006-01-02", "2021-08-25")
+	date, e := time.Parse(time.RFC3339, "2023-03-02T10:30:43-06:00")
+	t.Logf("date: %v", date)
 	if e != nil {
 		panic(fmt.Errorf("time.Parse: %w", e))
 	}

pkg/testdata/check1.json

@@ -1,5 +1,5 @@
 {
-   "date": "2021-08-25",
+   "date": "2023-03-02T10:30:43-06:00",
    "repo": {
       "name": "org/name",
       "commit": "68bc59901773ab4c051dfcea0cc4201a1567ab32"

pkg/testdata/check2.json

@@ -1,5 +1,5 @@
 {
-   "date": "2021-08-25",
+   "date": "2023-03-02T10:30:43-06:00",
    "repo": {
       "name": "org/name",
       "commit": "68bc59901773ab4c051dfcea0cc4201a1567ab32"

pkg/testdata/check3.json

@@ -1,5 +1,5 @@
 {
-   "date": "2021-08-25",
+   "date": "2023-03-02T10:30:43-06:00",
    "repo": {
       "name": "org/name",
       "commit": "68bc59901773ab4c051dfcea0cc4201a1567ab32"

pkg/testdata/check4.json

@@ -1,5 +1,5 @@
 {
-   "date": "2021-08-25",
+   "date": "2023-03-02T10:30:43-06:00",
    "repo": {
       "name": "org/name",
       "commit": "68bc59901773ab4c051dfcea0cc4201a1567ab32"

pkg/testdata/check5.json

@@ -1,5 +1,5 @@
 {
-   "date": "2021-08-25",
+   "date": "2023-03-02T10:30:43-06:00",
    "repo": {
       "name": "org/name",
       "commit": "68bc59901773ab4c051dfcea0cc4201a1567ab32"

pkg/testdata/check6.json

@@ -1,5 +1,5 @@
 {
-   "date": "2021-08-25",
+   "date": "2023-03-02T10:30:43-06:00",
    "repo": {
       "name": "org/name",
       "commit": "68bc59901773ab4c051dfcea0cc4201a1567ab32"