Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Fixes permission for main.yml action #1022

Merged
merged 1 commit into from
Sep 15, 2021

Conversation

naveensrinivasan
Copy link
Member

  • Please check if the PR fulfills these requirements
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fix

  • What is the current behavior? (You can also link to an open issue here)
    Scorecard repo fails at Token-Permissions with score 0 #942

  • What is the new behavior (if this is a feature change)?
    Fixes the permission for main.yml

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    None

  • Other information:
    None

@github-actions
Copy link

Integration tests success for e59ba4ad60a9cb0767128ff03825bba5a105b8a1

@@ -18,6 +18,8 @@ jobs:
validate:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add permissions: at the top of file too? If someone ever adds a new job and forget the permissions, it will default to all permissions.

@naveensrinivasan naveensrinivasan merged commit 1e4f723 into main Sep 15, 2021
@naveensrinivasan naveensrinivasan deleted the naveen/feat/fix-main-workflow-permission branch September 15, 2021 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants