Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow skipping scheme, fix regression. #106

Merged
merged 1 commit into from
Dec 22, 2020
Merged

Allow skipping scheme, fix regression. #106

merged 1 commit into from
Dec 22, 2020

Conversation

inferno-chromium
Copy link
Contributor

Fix regression from
f7cb4d7

@inferno-chromium inferno-chromium mentioned this pull request Dec 22, 2020
Closed
@inferno-chromium
Copy link
Contributor Author

TBR

@inferno-chromium inferno-chromium merged commit 9b1e28e into main Dec 22, 2020
@naveensrinivasan
Copy link
Member

There should probably a test to catch this.

@inferno-chromium
Copy link
Contributor Author

There should probably a test to catch this.

Can you add one, or i can do after i am back from holidays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlorenc dlorenc Awaiting requested review from dlorenc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inferno-chromium @naveensrinivasan