Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ [Check split]: Binary-Artifacts #1244

Merged
merged 10 commits into from
Nov 16, 2021
Merged

✨ [Check split]: Binary-Artifacts #1244

merged 10 commits into from
Nov 16, 2021

Conversation

laurentsimon
Copy link
Contributor

@laurentsimon laurentsimon commented Nov 12, 2021 •
edited
Loading

See #1245:

  1. the raw data collection: under checks/worker
  2. the score/policy evaluation: under checks/evaluation
  3. definition of structures for raw data structure: under checks/raw

Note: I've separated raw and worker simply because the structures will eventually be made public so I would like to have them all in one place... like C header files :-) An alternative solution would be to have both the data collection and the structure definition under raw and define each structure in the check that uses them. wdut?

no breaking changes

@laurentsimon laurentsimon changed the title ✨ [Check split]: Binary-Artifacts ✨ DRAFT [Check split]: Binary-Artifacts Nov 12, 2021
@laurentsimon laurentsimon marked this pull request as draft November 12, 2021 00:46
@laurentsimon laurentsimon marked this pull request as ready for review November 12, 2021 00:52
@laurentsimon laurentsimon changed the title ✨ DRAFT [Check split]: Binary-Artifacts ✨ [Check split]: Binary-Artifacts Nov 12, 2021
oliverchang
oliverchang reviewed Nov 12, 2021
View reviewed changes
checks/raw/binary_artifacts.go Outdated Show resolved Hide resolved
checks/worker/binary_artifact.go Outdated Show resolved Hide resolved
azeemshaikh38
azeemshaikh38 reviewed Nov 12, 2021
View reviewed changes
checks/worker/binary_artifact.go Outdated Show resolved Hide resolved
checks/worker/file_utils.go Outdated Show resolved Hide resolved
@laurentsimon laurentsimon force-pushed the feat/basplit branch 2 times, most recently from 8833409 to 929af25 Compare November 12, 2021 19:14
@laurentsimon laurentsimon mentioned this pull request Nov 13, 2021
Merged
@laurentsimon laurentsimon enabled auto-merge (squash) November 15, 2021 17:08
@laurentsimon
Copy link
Contributor Author

laurentsimon commented Nov 15, 2021 •
edited
Loading

Any other comment on this PR? Otherwise, can I get an LGTM :-)
Thanks!

@laurentsimon laurentsimon merged commit cc49494 into ossf:main Nov 16, 2021
@azeemshaikh38 azeemshaikh38 mentioned this pull request Nov 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naveensrinivasan naveensrinivasan naveensrinivasan left review comments

@azeemshaikh38 azeemshaikh38 azeemshaikh38 approved these changes

@oliverchang oliverchang oliverchang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@laurentsimon @naveensrinivasan @oliverchang @azeemshaikh38